WIP: increase ratelimit-burst-size for global use
unfortunately much more work than expected, due to how intertwined some of this is.
fully separating out frontend limits would probably simplify things, but there's more work to do to get there.
Codecov Report
Attention: Patch coverage is 87.50000% with 5 lines in your changes missing coverage. Please review.
Project coverage is 73.10%. Comparing base (
1771349) to head (05c121e).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| common/quotas/global/collection/collection.go | 66.66% | 5 Missing :warning: |
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| common/quotas/dynamicratelimiter.go | 76.92% <100.00%> (+10.25%) |
:arrow_up: |
| ...mmon/quotas/global/collection/internal/fallback.go | 96.49% <100.00%> (ø) |
|
| common/quotas/permember.go | 100.00% <100.00%> (ø) |
|
| common/quotas/ratelimiter.go | 82.53% <100.00%> (+3.69%) |
:arrow_up: |
| common/quotas/global/collection/collection.go | 83.63% <66.66%> (-1.39%) |
:arrow_down: |
... and 6 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1771349...05c121e. Read the comment docs.
I think the commit-message isn't aligned with the change. I would expect more like tweaking constants for ratelimit-burst-size. Is it?