cadence
cadence copied to clipboard
added test for dynamicconfig/configstore/config_store_client.go
What changed? Added test for uncovered lines in dynamicconfig/configstore/config_store_client.go
Why? To improve code coverage
How did you test it? locally using go test
Potential risks NA
Release notes
Documentation Changes
Pull Request Test Coverage Report for Build 018ee790-5061-42cf-96e2-3de5be2afab7
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 1228 unchanged lines in 22 files lost coverage.
- Overall coverage increased (+0.03%) to 67.407%
Files with Coverage Reduction | New Missed Lines | % |
---|---|---|
tools/cli/admin_db_decode_thrift.go | 1 | 71.79% |
common/persistence/nosql/nosqlplugin/types.go | 2 | 60.0% |
service/matching/taskReader.go | 2 | 84.88% |
common/task/weighted_round_robin_task_scheduler.go | 2 | 89.05% |
service/history/task/fetcher.go | 3 | 85.57% |
common/persistence/nosql/nosql_task_store.go | 5 | 61.95% |
common/task/fifo_task_scheduler.go | 5 | 84.54% |
service/history/task/transfer_standby_task_executor.go | 6 | 86.19% |
common/persistence/data_manager_interfaces.go | 8 | 96.51% |
common/persistence/nosql/nosqlplugin/errors.go | 12 | 0.0% |
<!-- | Total: | 1228 |
Totals | |
---|---|
Change from base Build 018ee46d-6495-47ba-900b-2030e24c5f31: | 0.03% |
Covered Lines: | 98263 |
Relevant Lines: | 145776 |
💛 - Coveralls
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 61.65%. Comparing base (
6d8466c
) to head (6c8f6b2
). Report is 64 commits behind head on master.
Additional details and impacted files
see 9 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6d8466c...6c8f6b2. Read the comment docs.
Looks like this tests were added as part of #5983 Closing the PR