Dalibor Karlović

Results 220 comments of Dalibor Karlović

@mre that's actually a really nice idea! :100:

I've created a similar issue for another project: https://github.com/wjdp/htmltest/issues/184 Basically, if you're generating for a specific subdirectory, it doesn't work as expected, for example: ``` # imagine a generator here...

@mre don't know if this is a new issue, so I'll shortly discuss it here since it's (IMO) related to the feature described here, which doesn't (yet) exists: if you're...

@mre OK, I'll create another issue to discuss the missing index file resolving, thanks!

Additional example: https://psalm.dev/r/11594ec601

@dpfaffenbauer yes: currently there are some items which are fetched in event listeners, regardless if they'll be required or not, this also applies to #1803. We should instead aim to...

Yes, this could be done in general for other listeners too. Generally, any expensive operation should be done after an (implicit or explicit) opt-in, not opt-out.

Maybe it can have a more general name to cover ISBN or MPN also? :thinking:

I think this is a fix specific to our usage of this, not for Coreshop in general. Closing.

Looking at the PR, it's very nice progress. I think the direction is good, but since the change set is so large, it seems to me there's a lot of...