Dalibor Karlović

Results 220 comments of Dalibor Karlović

It works, but I don't know if we could make it generic enough, a few things in how various totals are calculated would need to be revised first.

@aarongerig not really, it would need to be done on CS directly IMO.

Yes, that's exactly what I'm currently doing in my own project. :)

@breakone not understand what you mean here. If you check `\CoreShop\Component\Index\Condition\RangeCondition`, it actually allows both min and max to be nullable. The `RangeRenderer` you've linked is indeed buggy since it...

@breakone when you say "let's", does that mean somebody else will do it in this PR?

OK, I guess I understand. I don't see this as "right" though. This is guaranteed to make contributions more difficult though: to fix a bug, you first need to fix...

@dpfaffenbauer OK, we'll fix it. I can see this PR is mislabeled though, it's a bugfix since currently Coreshop just silently ignores the filter if both values are not set....

@davidhoeck can we fix the "not built for performance" upstream? I'd expect them to cache metadata in prod, same as any other integration.

@davidhoeck that's unfortunate. I'll check it out in Blackfire, thanks for the hint! :beers: