CoreShop icon indicating copy to clipboard operation
CoreShop copied to clipboard
verified publisher icon coreshop

In CategoryController, two conditions are added, but they are semantically filter preconditions

Open dkarlovi opened this issue 3 years ago • 1 comments

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

https://github.com/coreshop/CoreShop/blob/aeb14a9491128e377c5f3f61ab055d948a8c5deb/src/CoreShop/Bundle/FrontendBundle/Controller/CategoryController.php#L139-L140

These conditions should actually be filter preconditions because they behave exactly like that: https://github.com/coreshop/CoreShop/blob/aeb14a9491128e377c5f3f61ab055d948a8c5deb/src/CoreShop/Component/Index/Model/FilterInterface.php#L73

dkarlovi avatar Jul 08 '22 09:07 dkarlovi

PR?

dpfaffenbauer avatar Jul 11 '22 05:07 dpfaffenbauer

I think this is a fix specific to our usage of this, not for Coreshop in general. Closing.

dkarlovi avatar Aug 25 '22 14:08 dkarlovi