CoreShop icon indicating copy to clipboard operation
CoreShop copied to clipboard

Wishlist

Open IvanJavorovic opened this issue 2 years ago • 3 comments

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no

WIP new Wishlist bundle added to replace existing wishlist functionality. Review and changes are needed.

IvanJavorovic avatar Jun 27 '22 10:06 IvanJavorovic

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 27 '22 10:06 CLAassistant

Looking at the PR, it's very nice progress. I think the direction is good, but since the change set is so large, it seems to me there's a lot of similarities with Cart that we should be able to reuse more code maybe?

For example, let's say we introduce a "product comparison" feature in the future, it would also be a list of products which you can add/remove to a separate storage, it would seem wasteful to need to again add so much functionality. With this in mind, is there anything we could do to abstract code for better reuse here?

dkarlovi avatar Jul 05 '22 11:07 dkarlovi

@dkarlovi Absolutely! The plan was to first create the wishlist and check what we need, and then further refactor and abstract it. Stuff could move into the StorageList Component and maybe we also have to create a StorageListBundle to abstract and combine stuff. But I am looking into that

dpfaffenbauer avatar Jul 05 '22 12:07 dpfaffenbauer

@dkarlovi reworked a lot now to share more between Order and Wishlist, you might wanna check?

dpfaffenbauer avatar Aug 18 '22 13:08 dpfaffenbauer

thanks @IvanJavorovic for kicking this off

dpfaffenbauer avatar Aug 23 '22 06:08 dpfaffenbauer