danny comments

Results 137 comments of


                                            danny

Fork-choice integration test format and example (WIP)

Are you hand specifying the tests to ensure reuse of the cache or do you have a method to deduplicate given a set of tests?

1000 proposer slashings on the EF mnemonic were initiated by @dapplion on 2021/8/20. These have all been included [on chain](https://pyrmont.beaconcha.in/validators/slashings) with no adverse/unexpected effects

Relicensing original code to CC0

CC: @jrhea

Asserts in block process should result in the failure to process a block

gotta throw that shit out

Raise EJECTION_BALANCE from 16ETH to something higher

it's worth noting that this doesn't necessarily provide much speed up for "As a bonus, higher EJECTION_BALANCE speeds recovery when the network is not finalizing." Validators are added to exit...

Possible beacon chain changes for phase 1

"Fixes to rewards during inactivity leak" addressed in #1830 and removed from this issue

[DRAFT] Generate Hive Test Fixtures

@marioevz Where do you stand on this? Do you want to get this cleaned up to get merged? Or want to leave as draft for now

Improve Altair pytest coverage

I did a pass on coverage needed in state transition and am documenting progress here: https://docs.google.com/spreadsheets/d/1CbJy3iCRfXnG_jclMrDpktE-gEOXP9nAtGzoUYmuLVM/edit#gid=0

EIP-7594: Decouple network subnets from das-core

I haven't done a detailed review of how you do the layering here, but I generally support this direction to ensure that core protocol and network are sufficiently decoupled so...

danny