consensus-specs icon indicating copy to clipboard operation
consensus-specs copied to clipboard

Improve Altair pytest coverage

Open hwwhww opened this issue 4 years ago • 2 comments

  • [ ] [phase0] beacon
  • [ ] [phase0] fork choice tests (#2487)
    • some conditions were never be satisfied or be false.
    • [x] filter_block_tree never returns False
    • [x] should_update_justified_checkpoint never returns True
    • [x] update_latest_messages: condition i not in store.latest_messages or target.epoch > store.latest_messages[i].epoch was never False
    • [ ] on_block: state.current_justified_checkpoint.epoch > store.justified_checkpoint.epoch was never False
      • edited: currently commented out
  • [ ] [phase0] validator
    • get_committee_assignment never returns None
    • get_aggregate_signature is uncovered
  • [ ] [phase0] weak subjectivity
    • the whole spec is untested
  • [x] [altair] validator & networking (#2499, #2505)
    • some helper functions are uncovered
    • get_sync_committee_message
    • get_sync_committee_selection_proof
    • is_sync_committee_aggregator
    • get_contribution_and_proof
    • get_contribution_and_proof_signature
    • get_sync_subcommittee_pubkeys

hwwhww avatar Jun 15 '21 16:06 hwwhww

I'd pick fork choice & validator guide tests. 👋

hwwhww avatar Jun 15 '21 16:06 hwwhww

I did a pass on coverage needed in state transition and am documenting progress here:

https://docs.google.com/spreadsheets/d/1CbJy3iCRfXnG_jclMrDpktE-gEOXP9nAtGzoUYmuLVM/edit#gid=0

djrtwo avatar Jul 02 '21 21:07 djrtwo

I am closing this issue because it seems stale. Please, do not hesitate to reopen it if this is a mistake

leolara avatar Jun 04 '25 09:06 leolara