dan sinclair comments

Results 219 comments of


                                            dan sinclair

Create pre-built binaries

It also requires complication with vulkan-loader (which all our bots do as none of them have the SDK installed)

SwiftShader emits warnings (and so fails tests) due to subgroup size control

@paulthomson we should fixup the subgroup setup code to only happen if the extension is supported. @ben-clayton we build swiftshader Debug because ... I didn't think about it and just...

SwiftShader emits warnings (and so fails tests) due to subgroup size control

SGTM.

AmberScript: document that DRAW_RECT ignores VERTEX_DATA and INDEX_DATA on the given pipeline

sgtm

Improve portability of samples in tests/cases: use supported vertex formats

@sarahM0 how much of this is left? I know a bunch got changed with the doBuffer support?

Improve portability of samples in tests/cases: use supported vertex formats

Awesome, thank you for reviewing all of them.

Improve portability of samples in tests/cases: use supported vertex formats

Were you able to review the `compute_push_const_*` tests to determine if they needed changes? Sounds like this bug can be closed out and we can make specific bugs in the...

check_language.py misc. problems

I've run into both of those problem myself. I don't know the best way to find `python3` on a system. Maybe I can check if we're under `python2` and error...

Add example in Memory Views section showing a ref type.

That seems fine, as long as there is a link from the memory views section to see the example.

Update comment about reference types not appearing to a note.

Notes are all non-normative? I just wanted a way to make it stand out more, it wasn't the wording, just to a make it a lot more obvious.