David Iglesias

Results 302 comments of David Iglesias

> @stuartmorgan @ditman can you help us figure out why CI is failing? @johnpryan "submit-queue" is the check that asserts that whatever is at the tip of flutter/packages main branch...

Updated branch to fix merge conflicts. @chunhtai I've seen you've made some comments *after* LGTMing. Please, take another look, and if you're still good with this landing, set the `autosubmit`...

Refreshed documentation for `HtmlElementView` has just landed in the `main` branch API docs: * https://main-api.flutter.dev/flutter/widgets/HtmlElementView-class.html

Safari seems unhappy with the change, a couple of these: ``` 00:08 +298 ~7 -1: text_editing_test.dart: HybridTextEditing inserts element in the correct view [E] Expected: true Actual: ```

@mdebbar is this ready for review and I've been blocking it for a while now?

Can we make this a Draft PR for now then?

Sorry I missed the earlier message! There's at least two relevant changes to the SDK: * https://main-api.flutter.dev/flutter/dart-ui_web/browser.html (exposed the browser detection from the engine, currently in `master`) * we're looking...

I'm going to close this PR since it's still blocked, I'll revisit when we solve https://github.com/flutter/flutter/issues/91869

I simplified this a good bunch, so it's easy to rip out when we come up with a better (bi-directional) event system. PTAL @goderbauer @yjbanov @mdebbar!

I think I addressed all the comments @goderbauer, PTAL! PS: I have a change in: `packages/flutter_test/lib/src/test_pointer.dart` Do I need to split this PR in two, so I can land and...