David Iglesias

Results 302 comments of David Iglesias

Can do, thanks for the mention @jmagman, I normally disregard webview stuff because I end up flagged as an owner (but I'm not :P) Ahem: * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cyclic_object_value#circular_references

The biggest problem I see with this is that this is a "lossy" fix; what you deserialize is *not* what you were serializing; `"[Cyclic]"` might be good for the json...

Ah! I didn't realize this was to implement `console.log`. In that case, this is probably fine. The way this works in the browser is by it not attempting to "toString"...

Do you need both rendering modes at the same time, or do you always use the image-to-canvas mode? If only the canvas mode: Should this be a separate package of...

@jezell what browser are you targeting? I'm guessing Safari? This can't be the default method because `requestVideoFrameCallback` [doesn't seem to be supported at all on Firefox](https://caniuse.com/mdn-api_htmlvideoelement_requestvideoframecallback)? I guess it can...

@jezell I'm not opposed to merging this, because I like that it brings new features that were impossible before (filtering, probably access to the stream of frames) but it's a...

There's some dart analyze issues, but those should be straightforward to fix. A couple of tests are complaining, though: ``` The following PlatformException was thrown running a test: PlatformException(MEDIA_ERR_SRC_NOT_SUPPORTED, MEDIA_ELEMENT_ERROR:...

Another issue with this new technique is that it exposes the video_player_web to the same CORS problems that the NetworkImage has in the canvaskit renderer: [videos need to satisfy CORS...

Thanks for reverting the `web` package @pdenert! I checked the web APIs again and there's nothing new to `limit` the number of files that the user selects (as in: disable...

@srawlins if you're finding these inside `integration_test`s of web packages, I think you should be able to just `//ignore_for_file`. The analyzer doesn't understand that these tests belong to the parent...