David Iglesias
David Iglesias
> do we want to have the polyfill in the plugin, vs exposing the location API to allow this code to live as a separate third-party package to do a...
> But even if it's plugin specific, is that a problem? If people using our Maps plugin and who want specific extras functionality can install a third-party package to get...
There's an incoming migration to `package:web` that would make this PR more complicated, let's have [that PR](https://github.com/flutter/packages/pull/5254) land first, and then I'll update this one with the latest code, and...
> it is important to have good documentation to have information how to control the sizing, with BitmapScaling.noScaling or with the imagePixelRatios or size parameters, Flutter is able to pick...
> On web the image width and height need to be always devided with devices pixel ratio as it render everything too big by default More precisely, the web uses...
``` �[31mThe following packages had errors:�[0m �[31m google_sign_in/google_sign_in: google_sign_in/google_sign_in/example (Android)�[0m �[31mSee above for full details.�[0m ``` It's very nice that the CI is catching that I'm breaking the Android compilation....
(Android seems to be happy again)
Making PR "ready for review" after pushing some extra tests.
> Someone other than me will need to review the actual web parts. I'll find somebody to review the web bits as well. Thanks for the rest of the review,...
Rather than rebasing this branch, I'll start creating the independent PRs off of the latest master.