David Iglesias comments

Results 302 comments of


                                            David Iglesias

[camera] Ignore implementation imports outside of lib

Thanks @srawlins! Also, if you want to make one big PR with all the changes, I'll get it reviewed and merged as soon as I see it! (or maybe I...

[camera] Ignore implementation imports outside of lib

Yep, I'll try to get this later tonight.

[camera] Ignore implementation imports outside of lib

It seems the `implementation_imports` lint is already enabled: * https://github.com/flutter/packages/blob/main/analysis_options.yaml#L102 But my analyzer is not picking any of those up: ```console dit@dit:/work/flutter/packages/packages/camera/camera_web/example/integration_test$ flutter analyze . Analyzing integration_test... No issues found!...

[camera] Ignore implementation imports outside of lib

Ahhh oof, didn't realize this was a change in the behavior of the lint itself! (PS: will try again tomorrow, it's a little bit late now in PT!)

[camera] Ignore implementation imports outside of lib

Agh, totally forgot about this one. Thanks @srawlins! 🙇

[google_maps_flutter] Add marker clustering support - web implementation

Seems to work on my machine!

[google_maps_flutter] Add marker clustering support - web implementation

@jokerttu I've created a fix for the JS-interop layer and left it on your repo: * https://github.com/CodemateLtd/packages/pull/6

[google_maps_flutter] Add marker clustering support - web implementation

Giving this a final test, want to see if the plugin still works without adding the clustering JS dependency (obviously NOT on the clustering screens, but elsewhere :))

[image_picker] Adopt code excerpts in README

Looking!

[image_picker] Adopt code excerpts in README

I moved the test to `integration_test` and added the missing `IntegrationTestWidgetsFlutterBinding.ensureInitialized()`... I also did other changes (to ensure that the PNG image is a valid one), but I'm not sure...