Denis Žoljom

Results 296 comments of Denis Žoljom

I've updated the readme and `package.json` with scripts to run it locally, without global installation.

I'll try running this on my windows machine tomorrow.

On my windows machine, it runs fine, both start and builds, although I cannot see the docs in the sidebar, which is weird.

I could try to provide a basic `webpack.config.js` file, but it's a bit problematic because people put their assets in different folders, so this config would presume that you use...

I've added the webpack example here: https://github.com/WPTRT/customize-section-button/tree/feature/add-webpack-config If it's too complicated let me know. I've changed some things (using scss and some minor modifications as well).

> The /public folder seems to be gone from that branch?? Yes, since when you build the resources it will be made with hash added to it (that's why there's...

I agree, it mustn't be super rigid, but I'd still like to have some basic issue and PR templates set up. Helps with contributing. Oh and CONTRIBUTING.md file would also...

Also, we should take into account the coding standards (https://github.com/WPTRT/WPThemeReview). The WordPress CS follow structure and logic from the official handbook. We've also organized our namespace in a similar way...

We should work towards unifying this. Sniffs do follow rules in the requirement pages. And there are a lot of issues that will need to be categorized properly.

Is this related to why the PHPStan reports for this: ```php if ($query->have_posts()) { while ($query->have_posts()) { $query->the_post(); $list[] = [ 'id' => \get_the_ID(), 'title' => \get_the_title(), 'url' => \get_permalink(),...