Denis Žoljom

Results 369 comments of Denis Žoljom

Hi! I recommend that you use WPCS using Composer per project. Installing it globally could cause conflicts if you are using Composer in your projects, and dependencies clash. In your...

That would be awesome! I've run into this problem yesterday, where I ended up one hour debugging the issue where I typed `add_action( 'wp_handle_upload', ...` instead of `add_filter( 'wp_handle_upload', ...`,...

@GaryJones Nope, the `tab-width` property won't work, since it's not defined in the [ArrayIndentationSniff](https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/blob/develop/WordPress/Sniffs/Arrays/ArrayIndentationSniff.php#L29-L67).

> WPCS sets the tab-width to 4, so if you include any of the WPCS rulesets, you need to overrule this. To do so, you need to pass after the...

Nope, 2 spaces throughout the code (deviation from the traditional WPCS)

OK, I'll reopen the issue since adding `` didn't solve the original issue. But I noticed that if I add either ```xml ``` or ```xml ``` to the ruleset, the...

Hmmm maybe this is a PHPCS issue? 🤔

I changed a lot in the meantime, but looking at the old codebase, I used ```xml ``` Before defining the `WordPress.Arrays.ArrayIndentation`, which is basically the same as including the `WordPress`...

My two cents: > Do we want to keep the "new by reference" check ? Isn't that like PHP4 thing? You've mentioned that PHP compatibility already has this check, so...