Denis Žoljom

Results 369 comments of Denis Žoljom
trafficstars

I'm fine with having one code example covering all the things, we opted for splitting it into several paragraphs for easier maintenance.

@GaryJones I've made some changes based on the discussion I've had with Juliette: - Left the specific parts about the order for certain OO constructs - Create only one code...

`WPThemeReview` has some new features, but also has an issue with false positives, especially in escaping and prefixing sniffs. It can be used (it's used in Twenty Twenty theme), but...

I'd add this to es docs plus a separate how-to article.

![image](https://user-images.githubusercontent.com/8638515/186177080-599e7e90-cfa5-44d4-98ad-1e6f55a1c401.png) Escaping should also be fixed (removed)

The PR was made but I need to just cherry pick things from it: https://github.com/infinum/eightshift-libs/pull/303

Just a note, any instance of a gendered pronoun can be replaced with a more inclusive `they/them` alternative 🙂

@mbmjertan thanks for the test, I'll try to reproduce this and fix the issues 👍🏼

@mbmjertan Can you check if this works for you now? I've fixed the tests and parts that were failing, and also removed the unneeded rsync call

Looks good, but I'd like to go through the added functions, just to be safe (no pun intended) 😅