Denis Žoljom

Results 369 comments of Denis Žoljom

Thanks, I'll just have to ignore this line per line 😅

Yeah, I'd like not to ignore all those cases, because it might ignore legitimate notices 🙂 So one by one would be good alternative 😄

Hi! You'll need to provide a bit more details. Which version of PHPCS and WPCS are you using? Did you install it via composer or globally? What PHP version are...

> [Running in Travis](https://github.com/WordPress/WordPress-Coding-Standards/wiki/Running-in-Travis) - the workflow will need to be changed to not clone the repos, but use a Composer install. We will leave this for legacy reasons? Since...

For the fun of it, I just added ```php $this->classname_tokens[ \T_OPEN_CURLY_BRACKET ] = \T_OPEN_CURLY_BRACKET; $this->classname_tokens[ \T_CLOSE_CURLY_BRACKET ] = \T_CLOSE_CURLY_BRACKET; ``` To the list of classname tokens and ran the phpcbf...

This doesn't seem to be fixed, or I'm doing something wrong. I have a code like ```php echo Components::render( 'modal', array_merge( $attributes, [ 'modalContent' => Components::render('video', $attributes), 'modalId' => $buttonModalId,...

I kinda had to dig through the sniff and I think the issue is that the check for `autoEscapedFunctions` and `escapingFunctions` only happens inside the ```if ( \T_STRING === $this->tokens[...

Yeah, tricky. Could we add a new public property That would have a `name`, `type` (array) and a `value` that would denote the class? Then for every class the elements...

Yeah, so it's a limitation from the upstream. Are there any chances the configuration can be modified in v4 of phpcs?

What I thought was: is there a way to provide properties that will be parsed in the sniff as ```php $customAutoEscapedMethods = [ 'ClassName' => [ 'custom_method_1', 'custom_method_2', 'custom_method_3', ],...