Denis Žoljom

Results 369 comments of Denis Žoljom

One option would be to ignore `woocommerce` folder from the theme, but I wouldn't do that (those files shouldn't have errors or things like iframes for instance). The globals thing...

Can you open an issue, or comment on a new one in the WPCS repo? 🙂

Yeah, just looked at my theme and it's jpg 🙂

I agree, if we want to encourage people to write uniform readmes, we can notify if the `readme.txt` is missing or not. I wouldn't forbid the `readme.md` but it shouldn't...

Leaving a comment for future self. Some additional tests should be added for custom taxonomies, hierarchical taxonomies(passing IDs, and not names/slugs), passing multiple different slugs, etc.

Hi @SenselessTaste! You can do this by using either FSE features (we avoid using them, they are still changing so it's not that 'safe' to use them) or with reusable...

I'd like to investigate the behavior of this global object here. In general we should definitely avoid using globals as much as possible (you never know what you may get,...

If it's a big change that would take a couple of hours/days to implement I'd say, for now, leave it as is. We can optimize this in the projects later...

I wouldn't push this into the libs. If we would add something like this, I'd rather make it a separate JS/PHP package that can be pulled into the project per...

I'll merge this when I test this on an example project. So far the build process is broken so I'm blocked on this. Ref. https://github.com/infinum/eightshift-libs/issues/144