WordPress-Coding-Standards icon indicating copy to clipboard operation
WordPress-Coding-Standards copied to clipboard

Published 20 hours ago • verified publisher icon WordPress

add common functions that return int/float to escaping functions

Open kkmuffme opened this issue 3 years ago • 2 comments

https://github.com/WordPress/WordPress-Coding-Standards/issues/1969

count rand random_int ceil floor round

kkmuffme avatar Sep 04 '22 10:09 kkmuffme

Looks good, but I'd like to go through the added functions, just to be safe (no pun intended) 😅

dingo-d avatar Sep 05 '22 08:09 dingo-d

Yes please, take your time. I grabbed them off of psalm only taking global, non-class functions

kkmuffme avatar Sep 05 '22 10:09 kkmuffme

The code was moved to a different file with WPCS 3.0.0 and no more feedback given, will probably not get merged.

kkmuffme avatar Dec 07 '23 20:12 kkmuffme

@kkmuffme you could have rebased this PR, and we could have given it another look, no need to close it 🤷🏼‍♂️

dingo-d avatar Dec 08 '23 13:12 dingo-d

It's easier to create a new PR than rebasing this one, bc there are tons of rebase conflicts since the files this code is in has changed and also they're sorted alphabetically now already (which this PR did too).

If you still want a new PR, that's no problem, I can PR it :-)

kkmuffme avatar Dec 08 '23 15:12 kkmuffme