Dimitar (Mitko) Asenov

Results 19 comments of Dimitar (Mitko) Asenov

Hmm, I'm pretty sure when this bug was filed, the cursor disappeared completely and it impossible to continue typing. Now since recent changes the behavior has improved and at least...

Hmm, this actually feels like a super heavy approach. I was thinking more along the lines of having a normal item that has the QGraphicsItem::ItemClipsChildrenToShape flag set: http://doc.qt.io/qt-5/qgraphicsitem.html#GraphicsItemFlag-enum

I am able to do this. Are you sure you're trying the right thing? Remember that the argument name appears above the type. Once you type the name press Enter...

@hawkinsp @jakevdp Could you please have a look at this PR and approve if it looks good to you?

Hi @hsharsha It seems that #11567 is merged. Please take a look and adjust the current PR when you have the time. Thanks.

@ddunl This breaks our internal build and my attempts at fixing it weren't successful, could you please take a look and suggest a good way to land this fix? Thanks!

The breakage introduced by [df736d7](https://github.com/openxla/xla/commit/df736d78858f53bb957fd9c8db9d36af353d22e9) was fixed in a previous change, so I'm submitting just the part of this PR that fixes the breakage introduced by [ffa7bb5](https://github.com/openxla/xla/commit/ffa7bb52cc98c8a6a44f49128356fc71a694817d).

I'm looking into this, there's some google internal bits that we need to add on our end.

@ddunl, could you please take a look at the internal errors? I think we need to adjust the copybara config, but I'm not sure what's the right tweak.

I'm working on merging this internally.