xla icon indicating copy to clipboard operation
xla copied to clipboard

Published 20 hours ago • verified publisher icon openxla

Fix order of operations in failing transpose test

Open hsharsha opened this issue 10 months ago • 3 comments

hsharsha avatar Apr 04 '24 20:04 hsharsha

Hi @hsharsha , can you look into the comments? Thanks.

kamaljeeti avatar Apr 16 '24 07:04 kamaljeeti

Hi @hsharsha , can you look into the comments? Thanks.

Looks like this is similar to https://github.com/openxla/xla/pull/11567/ Will use the same pattern matching once that PR is accepted

hsharsha avatar Apr 16 '24 16:04 hsharsha

Hi @hsharsha It seems that #11567 is merged. Please take a look and adjust the current PR when you have the time. Thanks.

dimitar-asenov avatar May 15 '24 19:05 dimitar-asenov

I think there are changes made to indexing maps and string matching ir. I will close this PR as the test is passing now and will revisit if there is a failure in the future.

hsharsha avatar May 16 '24 15:05 hsharsha

I think there are changes made to indexing maps and string matching ir. I will close this PR as the test is passing now and will revisit if there is a failure in the future.

hsharsha avatar May 16 '24 15:05 hsharsha