xla icon indicating copy to clipboard operation
xla copied to clipboard

Published 20 hours ago • verified publisher icon openxla

[XLA:GPU] Add sycl platform

Open ShengYang1 opened this issue 10 months ago • 3 comments

It is a sub PR of https://github.com/openxla/xla/pull/9042 to add sycl platform

ShengYang1 avatar Apr 11 '24 03:04 ShengYang1

@golechwierowicz friendly ping!

thomasjoerg avatar May 06 '24 12:05 thomasjoerg

So sorry for the delay! I have minor comments.

Thanks:) I have addressed all of your comments.

ShengYang1 avatar May 08 '24 01:05 ShengYang1

Hi @penpornk This PR has been approved but not yet merged, Can you please look into this.

NaiyerRizz avatar May 14 '24 09:05 NaiyerRizz

I'm looking into this, there's some google internal bits that we need to add on our end.

dimitar-asenov avatar May 16 '24 13:05 dimitar-asenov

@ddunl, could you please take a look at the internal errors? I think we need to adjust the copybara config, but I'm not sure what's the right tweak.

dimitar-asenov avatar May 21 '24 08:05 dimitar-asenov

There's a new policy requiring all new PRs adding new functionality to provide tests. Could you please add a test that creates a mock SYCL device and test the SYCL platform functionalities added in this PR? Thank you very much!

I've been working on the tests but encountered a challenge due to the dependencies of this PR. Currently, the code can only be built but not fully run since it relies on symbols(GpuDriver/GpuExecutor) which should be covered in other PRs. Is it possible to add those tests when SYCL stream-executor PRs are fully merged?

ShengYang1 avatar Jun 07 '24 02:06 ShengYang1

I'm working on merging this internally.

dimitar-asenov avatar Jul 10 '24 08:07 dimitar-asenov

This was merged by https://github.com/openxla/xla/commit/c781e75f7ce803189f80ab1ec167920c011cece5

dimitar-asenov avatar Jul 15 '24 10:07 dimitar-asenov