Friedel Ziegelmayer comments

Results 767 comments of


                                            Friedel Ziegelmayer

refactor(iroh): Remove gossip rpc types

Ref https://github.com/n0-computer/iroh-gossip/pull/4

refactor(iroh): Remove gossip rpc types

still some ci issues, otherwise lgtm

flaky test: iroh-cli::cli cli_rpc_lock_restart (macos)

Closing, as we have removed `iroh-cli`

refactor: switch to hex formatting

Greaaat.. labels can only be 63 bytes in local swarm discovery/dns land, meaning hex encoding won't fit.... 😭

refactor: switch to hex formatting

closing in favor of #3042

invalid merge: `ring`

switching to `inset-ring` it passes, I am not clear if I am missunderstanding sth, or this is a bug tbh

feat: use Raw Public Keys instead of self signed certificates

thanks for the update @cpu !

feat: use Raw Public Keys instead of self signed certificates

Current implementation plan: Add support for this to `iroh-net` and `iroh` using an option ```rust fn set_tls_authentication(auth: TlsAuthentication) { .. } pub enum TlsAuthentication { // Current self signed certificates...

feat: use Raw Public Keys instead of self signed certificates

It looks like there is some movement to support both on rustls: https://github.com/rustls/rustls/issues/2258 this would be amazing as this would allow us to mgirate without a breaking network change

Make compatible with tokio

most of this is working, but there are some subtle issues in the tokio reading logic which I haven't figured out yet