Friedel Ziegelmayer comments

Results 767 comments of


                                            Friedel Ziegelmayer

Import `offset-cookbook-mode`

applied the missing CR in here: https://github.com/RustCrypto/AEADs/pull/587

Preserve info about which addresses are local in `AddrInfo`

we have these helpers already implemented here: https://github.com/n0-computer/iroh/blob/main/iroh-net/src/net/ip.rs

fix: make signature equality more robust

I don't think this is good to do. If you want a more relaxed version we could add a "is_similar_to" method or sth like that, but equality should really check...

Performance improvements

> Wondering about aligning the signed message reader buffer sizes with the others (and maybe the compressed one, as well?) not really, other than me being lazy..

'error flushing netlink socket (Permission Denied)' when trying to run iroh on android via termux

yes, newer android is very restrictive, which is why reading network interfaces is quite..complex https://github.com/shellrow/netdev/pull/22 I suspect under `termux` the detection of it being a problematic android device fails (I...

'error flushing netlink socket (Permission Denied)' when trying to run iroh on android via termux

Closing as it is unclear if this is sth we can do on the iroh side for this

Maybe rename PublicKey/PublicSubkey::sign() to be more expressive

I like the longer forms, `bind` is very opaque

feat(iroh-net): add Endpoint::watch_node_addr

Closing this, as we now have the watcher based API

Adopt RustCrypto new releases

the overall changes are a lot simpler than I expected, which is nice

Adopt RustCrypto new releases

That failure means that some parsing logic has changed. One trick is to run the test with logging on the branch before and after and look at the diff, where...