Cristiano Rastelli
Cristiano Rastelli
@aklkv don't forget to add a changeset to the PR
> I realize you have a pending question, but if that the response doesn't block this merge, everything else looks good. @dchyun do you think we should wait for a...
@dchyun @hellobontempo all the tests are green, can you re-review? thanks (I'll rebase once approved, and ask a quick re-approval)
@hellobontempo I've committed your suggestion. When you have time can you re-approve? thanks
It's quite a complex PR with potential side-effects. Maybe @RobbieTheWagner could review it too?
I'm moving the PR to draft because there are too many failing visual regression tests in Percy, and I want to think a bit more about potential alternative solutions.
@dchyun @KristinLBradley unfortunately a wrong origin definition in my local Git client made so that I pushed to the wrong branch (the parent) instead of this one, which made GitHub...
@zamoore can you please move this PR to draft? the reasons I am asking are 1) we tend to avoid doing the conversion of two different/distinct components in the same...
> > @zamoore can you please move this PR to draft? the reasons I am asking are 1) we tend to avoid doing the conversion of two different/distinct components in...
> Are the Percy visual diffs all as expected? The preview for the `AdvancedTable` looks like something broke when it was generating for some reason. @KristinLBradley I don't know why...