Cristiano Rastelli

Results 85 comments of Cristiano Rastelli

@hellobontempo I think we've [reached a consensus](https://docs.google.com/document/d/1IVwBbMHLaVxEzhlyDwHcW-oo3X8XiTbIoXVwxsSNJiA/edit?tab=t.0#heading=h.65fnkcsypnmn) that this is the way to go. Do you mind doing also the second part in this PR, which is to remove the...

> Does this need a changeset? Yes, I think so.

@KristinLBradley something to consider: instead of three arguments, have an object as argument (I think the Grid is implemented in this way, or some other layout component; I can look...

@alex-ju I'm looking at this to see if I remember something more of what I did and why

@alex-ju something very weird is happening here. Compare the source code: With how it's compiled: I need to investigate more...

@alex-ju I went back to a previous commit (https://github.com/hashicorp/design-system/pull/2361 and since then the logic has not been changed); then I looked at how the code would be compiled, and from...

@alex-ju @aklkv I was able to narrow down the PR that introduced this regression and it is this one: https://github.com/hashicorp/design-system/pull/2729 This is the generated code when you check out https://github.com/hashicorp/design-system/pull/2708...

> @didoo, your hunch was spot on. This type of check: > > ```js > const hasCover = frontmatter?.layout?.cover ?? true; > ``` > > was previously affected by a...

@alex-ju @aklkv the website issue with the sidenav has been fixed by #2884 (thanks @aklkv for the extra investigation) so we can close this PR (and the associated ticket): https://hds-website-git-chore-babel-hashicorp.vercel.app/about/principles

@alex-ju I've opened a specific PR for this: https://github.com/didoo/figma-api/pull/77 if you have time to review I can release and we can see it it solves the problem in Helios (https://github.com/hashicorp/design-system/security/dependabot/126)