[VAULT-34798] UI: move the `boolean` block in `FormField` under the HDS block
[!IMPORTANT] ⚠️ Based off #30762 to minimize conflicts - Don't merge until that PR is merged in
main(and remember to add the milestone too)
Description
What does this PR do?
- updated logic in
isHdsFormFieldofFormFieldto include thetype|editType === 'boolean'use cases - moved template logic for
type|editType === 'boolean'inFormFieldunder theisHdsFieldblock - fix a couple of failing tests by updating the selectors to match the new DOM structure
Jira ticket: https://hashicorp.atlassian.net/browse/VAULT-34798
TODO only if you're a HashiCorp employee
- [ ] Backport Labels: If this fix needs to be backported, use the appropriate
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.- [ ] LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
- [ ] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature of a public function, even if that change is in a CE file, double check that applying the patch for this PR to the ENT repo and running tests doesn't break any tests. Sometimes ENT only tests rely on public functions in CE files.
- [x] Jira: If this change has an associated Jira, it's referenced either in the PR description, commit message, or branch name.
- [ ] RFC: If this change has an associated RFC, please link it in the description.
- [ ] ENT PR: If this change has an associated ENT PR, please link it in the description. Also, make sure the changelog is in this PR, not in your ENT PR.
CI Results: All Go tests succeeded! :white_check_mark:
Build Results: All builds succeeded! :white_check_mark:
I realize you have a pending question, but if that the response doesn't block this merge, everything else looks good.
@dchyun do you think we should wait for a decision about the cursor: pointer? https://github.com/hashicorp/vault/pull/30771#discussion_r2114148707
I realize you have a pending question, but if that the response doesn't block this merge, everything else looks good.
@dchyun do you think we should wait for a decision about the
cursor: pointer? #30771 (comment)
@didoo no I think we can tackle that separately since it exists currently anyway.
@dchyun @hellobontempo all the tests are green, can you re-review? thanks
(I'll rebase once approved, and ask a quick re-approval)
@hellobontempo I've committed your suggestion. When you have time can you re-approve? thanks