David Barbet

Results 361 comments of David Barbet

I think this has just happened again in https://github.com/dotnet/roslyn/pull/63398 1. a119633 and 5d6915c were pushed to the PR (both at once, but 5d6915c is the last commit). 2. CI ran...

> @dibarbet > > I think it ran on 97fd9879915a25909a68a5ee7ea0b2db014e5f78 (the commit before a119633) you're totally right, updated my comment.

Again on https://github.com/dotnet/roslyn/pull/63408 f5356c9 showed checks from 4e6b2df (failed with an error fixed in f5356c9)

For whatever it is worth, Roslyn perf appears to be acceptable - with a p99.9 of 1.2-1.5s and p90 of 25ms ![image](https://user-images.githubusercontent.com/5749229/157785088-e5899e39-0320-43de-ab02-76e82b6f59ac.png)

@NTaylorMullen client controlled as of now. But I don't see why we couldn't support it through folding ranges. Could you transfer / file an issue on us?

@jasonmalinowski afaik this feature isn't turned on unless the LSP editor feature flag is turned on, so users shouldn't be hitting this. That being said I haven't tried myself so...

> @jmarolf Do we understand why the test platform APIs are so much slower? cc @nohwnd ~~My understanding is that we can run discovery with xunit using only two processes...

> > splits runtests into three projects. this will allow us to more easily remove runtests once integration tests switch over. > > The original runtests project which now only...

> Where is the doc for the flag so I can read up on it? Here! (see MaxCpuCount) https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2022#runconfiguration-element Unfortunately `dotnet test` doesn't expose a `parallel` (or similar) flag directly,...