roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

[LSP] Document highlighting throws exception with F# files

Open allisonchou opened this issue 2 years ago • 1 comments

Since syntax trees aren't supported in F#, this line throws an exception upon opening a default F# console app: https://github.com/dotnet/roslyn/blob/2297cd72e2224d140ba639d75432ddd0b0b5f0e7/src/Features/LanguageServer/Protocol/Handler/Highlights/DocumentHighlightHandler.cs#L72

cc @dibarbet

allisonchou avatar Sep 21 '22 00:09 allisonchou

This should likely be using IDocumentHighlightsService

CyrusNajmabadi avatar Sep 21 '22 00:09 CyrusNajmabadi

@dibarbet Did we already fix this? I assume we'd be getting lots of reports if we hadn't.

jasonmalinowski avatar Oct 03 '22 18:10 jasonmalinowski

@jasonmalinowski afaik this feature isn't turned on unless the LSP editor feature flag is turned on, so users shouldn't be hitting this. That being said I haven't tried myself so I will confirm.

dibarbet avatar Oct 03 '22 18:10 dibarbet