Bruno Dias

Results 274 comments of Bruno Dias

Hi @arcifius, don't know if this warning should be present. We are in a process of adapting the library for react `16.3+` and `17`. cc @Hypnosphi, if you can comment...

Can you try to downgrade react to `16.3.0` or `16.3.1`?

@StokeMasterJack we made some changes recently to api to define the `app element`. Can you get the log message you got?

Can you check if setting `Modal.setAppElement` the error goes away? Ref: [https://github.com/reactjs/react-modal#app-element](https://github.com/reactjs/react-modal#app-element)

Oh sorry, thought it was an error. This is related to this change #570. This is a reminder that not setting the app element will/can cause accessibility issues.

So, you need to explicit tell the modal that you don't want to use the app element with `ariaHideApp={false}` (if that's your case).

I'll keep this open. Documentation is missing for this behavior.

@dlong500 The documentation related to this is outdated. Also, we need to tests how the modal will work on a SSR environment. I did some tests to get it working,...

@lbelinsk Sure, it would be really great.

To all... This is the correct behavior for react-modal as already mention on this thread. As @catamphetamine already mention and many others that have been working with accessibility, there is...