Doug Fawley

Flaky Test: 1/10k: Test/RetryStats in grpc/test

4

https://github.com/grpc/grpc-go/actions/runs/3735324618/jobs/6338431713 ``` --- FAIL: Test/RetryStats (0.02s) tlogger.go:116: INFO clientconn.go:105 [core] [Channel #152] Channel created (t=+314.905µs) tlogger.go:116: INFO clientconn.go:1556 [core] [Channel #152] original dial target is: "127.0.0.1:44421" (t=+473.607µs) tlogger.go:116: INFO clientconn.go:1561...

server: Stats handler and InTapHandle called during critical read path

3

Moving the service handler goroutine forking into the transport (from `server.go`) would allow other reads to proceed without blocking on the tap/stats handlers.

Re-enable coverage reporting

1

Coverage results should not block merging, as they did before. Instructions: https://coveralls.zendesk.com/hc/en-us/articles/201342809-Go

Unsupported codec on server should fail with Unimplemented instead of attempting to use proto codec

3

https://github.com/grpc/grpc-go/blob/f1437f7cc5fa7525032e27aa5fdc15e288220c4e/server.go#L1433-L1435 This would be a behavior change, even though it's also a bug fix, so it would need to be carefully considered first.

This appeared in a flake of `Test/ConcurrentServerStopAndGoAway` in `test/`, but I believe there could be a real issue here. We've also seen the same thing in some integration tests we...

protoc-gen-go-grpc: add tests

6

We don't currently have any tests in `protoc-gen-go-grpc`. We should add something simple at least: 1. Create a `.proto` file with streaming / unary RPCs. 2. Generate the `.pb.go` file(s)...

https://github.com/grpc/grpc-go/blob/591c48187c4ba075d14a0ca6e69572a60662af92/xds/internal/xdsclient/tests/cds_watchers_test.go#L636

interop: interop functions should not call context.Background() for RPCs

4

E.g. https://github.com/grpc/grpc-go/blob/70f1a4045da95b93f73b6dbdd7049f3f053c0680/interop/test_utils.go#L82-L83 This function and all others in this file should accept a context, which would allow passing RPC timeouts, metadata, etc. `context.Background` is really only supposed to be called...