grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

interop: interop functions should not call context.Background() for RPCs

Open dfawley opened this issue 2 years ago • 4 comments

E.g. https://github.com/grpc/grpc-go/blob/70f1a4045da95b93f73b6dbdd7049f3f053c0680/interop/test_utils.go#L82-L83

This function and all others in this file should accept a context, which would allow passing RPC timeouts, metadata, etc. context.Background is really only supposed to be called by main/TestXyz functions wherever possible.

dfawley avatar Nov 03 '23 18:11 dfawley

hi @dfawley, can I pick this up?

Aditya-Sood avatar Nov 04 '23 04:11 Aditya-Sood

@Aditya-Sood Yes, that would be great! But note that we are going to be moving stress/* to interop/stress/*, so you might want to wait until that's done, first.

dfawley avatar Nov 06 '23 19:11 dfawley

I think that's done with the merge of #6769 now?

Aditya-Sood avatar Nov 07 '23 05:11 Aditya-Sood

@Aditya-Sood -- Yes that's right!

arvindbr8 avatar Nov 07 '23 21:11 arvindbr8