Doug Fawley
Doug Fawley
As requested in #2626, we should document all the fields available via the context as they are not really discoverable. The doc should include grpc functions like `SetHeader`/`Method`/etc as well...
It appears we don't ever set the necessary LRS fields in order for LRS to work in logical DNS clusters; only in EDS: https://github.com/grpc/grpc-go/blob/e14d5831b59b0f46853d076640ae85f964164b37/xds/internal/balancer/cdsbalancer/cdsbalancer.go#L610-L638 We should make sure it works...
To support the upcoming IPv4/IPv6 Dualstack design ([gRFC A61](https://github.com/grpc/proposal/pull/356)), some changes will be required in the `resolver` and `balancer`. We will also be taking this opportunity to streamline the APIs...
Several major changes are included: - Stop using an "ID" to reference the channelz object from the channel/etc that contains it. Instead get a pointer to the object directly. -...
Please see https://go.dev/play/p/-ex0P0JLOV0 to demonstrate how modifying the variadic argument of a function can alter the memory of the caller. It's unlikely a caller of a function like this would...
These APIs are labeled as [experimental](https://github.com/grpc/grpc-go/blob/87bf02ad24f6cc071d2553eb5d62332194bba1fe/balancer/balancer.go#L20), and they will be changed in the near-ish future. Details are in https://github.com/grpc/grpc-go/issues/6472. Note that any package that uses gRPC's experimental APIs should _itself_...
https://github.com/grpc/grpc-go/blob/9cf408ec48fe2b20d020b2430981a148fd93d187/internal/grpclog/prefixLogger.go#L65 If a parameter passed to these functions is expensive to evaluate, that expense is borne regardless of whether verbosity would output the message . All usages should be audited,...
After #7010 we need to make sure all our documentation recommends `NewClient`. We should still retain some tests for `Dial` but the majority of them should probably be converted to...