grpc.io icon indicating copy to clipboard operation
grpc.io copied to clipboard

fix class name typo

Open DenisPavlov opened this issue 3 years ago • 8 comments
trafficstars

DenisPavlov avatar Jun 10 '22 06:06 DenisPavlov

CLA Missing ID CLA Not Signed

@DenisPavlov - thanks for the PR, but you'll need to sign the CLA first before we can review it.

chalin avatar Jul 07 '22 20:07 chalin

@lowasser @bshaffer @jamesward - does this change make sense?

chalin avatar Jul 07 '22 20:07 chalin

Yes, the change is correct.

jamesward avatar Jul 07 '22 21:07 jamesward

@DenisPavlov - waiting for you to sign the CLA. After that I'll merge.

chalin avatar Jul 11 '22 21:07 chalin

Ping @DenisPavlov - can you complete the CLA please?

dfawley avatar Jul 27 '22 18:07 dfawley

I've signed CLA but don't understand my next step. @dfawley can you help me please?

DenisPavlov avatar Jul 28 '22 14:07 DenisPavlov

I've signed CLA but don't understand my next step. @dfawley can you help me please?

You don't seem to have signed the CLA with the same ID you used to commit. The commit ID is "Павлов Денис Валерьевич". You'll need to use the same account.

chalin avatar Jul 28 '22 17:07 chalin

Ping @DenisPavlov; are you able to complete this? If not maybe send a new PR using the ID that you signed the CLA with?

dfawley avatar Nov 30 '22 21:11 dfawley

Ping @DenisPavlov

easwars avatar Feb 15 '23 18:02 easwars

@ejona86 @temawi Same here with an unsigned CLA.

easwars avatar Oct 04 '23 18:10 easwars

I think enough time has passed for us to hope the CLA will ever get properly signed so I will close this PR.

temawi avatar Oct 04 '23 21:10 temawi

It's sad that a correctness typo can't be fixed without the user signing a CLA. Can a maintainer send a similar PR?

dfawley avatar Oct 04 '23 22:10 dfawley

In fact, anyone who has signed the CLA could send a similar PR 😉

I sent out #1205, could you sanity check me @dfawley?

temawi avatar Oct 04 '23 23:10 temawi