Alexander M. Turek

Results 630 comments of Alexander M. Turek

Thanks, dear bot. This is on me. I'll try to conduct a review soon'ish. 🤞

We indeed don't support extracting the enum cases in discriminator columns yet, but I don't see why we shouldn't. Do you want to work on this feature?

You can have a look at our existing functional test suite. You would basically create an entity model that reproduces your problem and write code that persists and fetches data...

> Well, when someone updates from 2.0 to 3.0, BC breaks are expected Yes, but they have to be prepared. This means that there has to be some way to...

We can do that, yes. But someone would need to work on the feature and apparently nobody did that during the last three years.

cc @VincentLanglet @greg0ire I'd like to replace the exception with a deprecation. Even if such calls don't make any sense, we shouldn't start throwing exceptions in a minor release on...

> I understand your point, but I'm afraid people might miss the warning and the fact the code is not executed when running the migration. They certainly will. But it's...

Thank you for your PR. However, I don't really feel we need this change, to be honest. Those listener objects are a piece of glue code solely meant to be...

> Changing the method name can be useful to convey what the method does. Sure, then have the handling method with the ugly event name call another method with a...