Alexander M. Turek
Alexander M. Turek
Sure. Do you want to work on it?
Also, please keep in mind that we only allow bugfixes on the 3.8.x branch. Your change however adds new functionality. For that, please target 4.1.x.
Schema comparison is still not covered.
> Formatter must never fail and never add any warning That's nice statement, but hardly an actionable issue. Can you please elaborate a bit more what the goal of this...
> one thing I'm not sure about is to how to treat variables without type, If there's no type, there's nothing we could infer nullability from. The old defaults are...
> Well, if you don't access that property, it does not need to be null, I'm using auto-increment and I have all my IDs non-nullable in code and in database,...
@alexndlm Did you review and test the change in your projects? I agree that we should try to get it merged.
> But I will do this soon to double-check. Thank you! I personally don't need this feature at the moment. So getting feedback from someone who'd actually use it is...
Thank you. Can you please add a functional test that actually creates such a foreign key?
No, your test compares the generated SQL. But that SQL still does not hit a database.