Alexander M. Turek

Results 440 comments of Alexander M. Turek

I think, we should deprecate `Symfony\Bridge\Monolog\Logger` in 6.2. That logic can be reimplemented easily without extending Monolog's `Logger` class.

> It appears that the Finder component is missing in CI. https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Filesystem/composer.json You can only use packages that appear in the component's dependencies.

We need to decide if we want to merge this change as a bugfix. @symfony/mergers I need a second opinion for this.

We've revised our policy regarding bugfixes recently, and I suppose we need to schedule this for 5.4 as a feature. Can you please do a rebase?

My question from April is still open: If we add a second iterator to the signature, we should have a test scenario in which both iterators are set.

> ### Symfony version(s) affected > > 6.5 Can you please check again? As far as I know, we haven't released a version 6.5 and we currently have no plans...

I like the basic idea of this feature, thank you for the PR. I however believe that it should be implemented differently. First of all, the marker interface. In a...

> Not sure if it's a good practice to "not validate" user data. No, but Symfony's validator is certainly not the only tool for that. If we add this functionality...

> Would it make sense to split this into 2 different features: one that deserialize input and one that validate controller arguments (with 2 separate attributes)? This would allow us...