Alexander M. Turek

icon indicating a website link https://derrabus.de icon indicating an email [email protected]

icon company @trbocom icon location Düsseldorf, Germany icon location Developer. @symfony Core Team. @doctrine Core Team. Likes working with code that has aged like a good whisky.

Results 630 comments of Alexander M. Turek

Fix bigint PHP_INT_MIN/PHP_INT_MAX string to int convert

Please don't ping me on PRs please.

Fix bigint PHP_INT_MIN/PHP_INT_MAX string to int convert

Please keep in mind that this piece of code will be executed on a hot path. If I hydrate thousands of entities with bigint fields, I don't want to execute...

Fix bigint PHP_INT_MIN/PHP_INT_MAX string to int convert

Sorry, but that implementation is way too complicated. I don't want to maintain this.

Fix bigint PHP_INT_MIN/PHP_INT_MAX string to int convert

Which DBMS formats 2^31-1 with leading zeros?

Fix bigint PHP_INT_MIN/PHP_INT_MAX string to int convert

🤷‍♂️

Fix bigint PHP_INT_MIN/PHP_INT_MAX string to int convert

> I am asking as the integer DBAL Type class can be used to load any value Sure, but it's not meant to be used on any value. And I...

Fix bigint PHP_INT_MIN/PHP_INT_MAX string to int convert

> in my company we use DBAL Types to cast data even from APIs for example But that's an off-label use and I hope you're fully aware of that. If...

Fix bigint PHP_INT_MIN/PHP_INT_MAX string to int convert

> I don't understand the problem The problem ist that if the DB would return PHP_INT_MAX as string, we would not convert it to int although one might expect that.

Fix bigint PHP_INT_MIN/PHP_INT_MAX string to int convert

As soon as the unnecessary changes to the test have been reverted, I'm fine with the PR.

Column precision is not specified 2

We've had a similar discussion in #6455: Postgres also supports `VARCHAR` without a limit which DBAL 4 "broke" as well. The problem is that those unconstrained types as Postgres calls...