Patrik Ragnarsson

Results 771 comments of Patrik Ragnarsson

How to reproduce? I tried this, but I don't see any problem. ```ruby $ cat rack3.ru app = lambda do |env| req = Rack::Request.new(env) pp req.content_type [200, {}, ["OK"]] end...

If it happens again, please share the full backtrace @AllyMarthaJ

Oh, I called the wrong method in my attempt to repro this! Check this out: ```shell $ echo 'require "rack"; port 8080; app { |env| req = ::Rack::Request.new(env); pp req.content_charset;...

Also a problem with current main branch (ecdce74686e991bdc50674194920ec0c0b8f3bd9) , tested with `echo '$LOAD_PATH.unshift("lib"); require "rack"; pp ::Rack::RELEASE; port 8080; app { |env| req = ::Rack::Request.new(env); pp req.content_charset; [200, {}, ["OK"]]...

I think we can close this since https://github.com/rack/rack/pull/2247 was merged?

Wow, I was just now taking a look at https://github.com/sinatra/sinatra/issues/2019 😅 My observation (from Sinatra tests) is that it does not happen with rack head, what more has changed?

You are right. That was incorrect info from me. Sinatra [can't even start its tests](https://github.com/sinatra/sinatra/actions/runs/9565078027/job/26367227454#step:5:13) at rack head currently.

Has been discussed in https://github.com/puma/puma/issues/2440

Intentional change @ioquatix @jeremyevans?

This is the test: https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/rack-protection/spec/lib/rack/protection/cookie_tossing_spec.rb#L29-L42 Added in 2016: https://github.com/sinatra/sinatra/commit/cd5028b5c961cd1beca01409a2cd1a3ee818da37 (https://github.com/sinatra/rack-protection/pull/113)