Patrik Ragnarsson

Results 771 comments of Patrik Ragnarsson

It is a gemfile without `rackup` (https://github.com/sinatra/sinatra/blob/319af3a298cb8278670f285b6c02df0fd084615d/test/integration/gemfile_without_rackup.rb)

Are all Sinatra tests (even contrib and rack-protection) now running correctly here? (I'm on mobile and lazy) So the "only" thing left is the adjustments in Sinatra? (the PRs linked...

I won't be able to work on this before October so if you have time, go for it

It is good practice to re-use the client connection and channel to avoid connection churn (see more at https://www.rabbitmq.com/docs/connections). However, it is also good practice (important) to separate publishing and...

I like the idea of this but it seems like it makes it a bit harder to use our released version when you have `~/.terraformrc`? When I had this ```hcl...

Looks like the way to go is the `TF_CLI_CONFIG_FILE` environment variable, and not use `~/.terraformrc`, mentioned in the docs over at https://developer.hashicorp.com/terraform/cli/config/config-file#development-overrides-for-provider-developers

That could be a breaking change if people for some reason had other things in the query string. I agree with using secure comparison but I think we can afford...

Connecting this issue with https://github.com/sinatra/sinatra/issues/2065 because they touch on the same topic. Disabling the host protection when disabling all protections sounds legit. Sounds like you should open a separate issue...

I was about to post a comment linking to this issue https://github.com/kubernetes/kubernetes/issues/94284 specially thinking of the last comment https://github.com/kubernetes/kubernetes/issues/94284#issuecomment-689901666 Interesting about the TLS cert... are you able to try amqproxy...