Patrik Ragnarsson
Patrik Ragnarsson
We just had this fail in CI: https://github.com/puma/puma/actions/runs/10688292588/job/29627986699#step:10:970 ``` /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/socket.rb:68:in 'Socket#connect': Errno::ENOENT: No such file or directory - connect(2) for /home/runner/work/_temp/puma_socket20240903-2914-q8h9mh (Puma::SdNotify::NotifyError) from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/socket.rb:68:in 'Addrinfo#connect_internal' from /home/runner/.rubies/ruby-head/lib/ruby/3.4.0+0/socket.rb:141:in 'Addrinfo#connect' from /home/runner/work/puma/puma/lib/puma/sd_notify.rb:140:in...
> This is the systemd notify socket, so it probably isn't the same issue as libev failures. > > The teardown code might be amiss, as the server might still...
Happened for the `ubuntu-22.04 3.2 rack2` job for https://github.com/puma/puma/pull/3589, log at https://github.com/puma/puma/actions/runs/12580493902/job/35062661418#step:10:444 ``` (libev) epoll_wait: Invalid argument /home/runner/work/_temp/6b5de6c8-8475-45ca-9362-076205407f49.sh: line 1: 2686 Aborted (core dumped) test/runner --verbose ```
Comment on this from https://github.com/sinatra/sinatra/pull/2030#issuecomment-2222305239 > However, it's parsing `set-cookie`, i.e. the return value from the application/server? Then it might not be so problematic.
@tomazzlender do you want to share the code for this? 😇 Maybe a gist
On the topic of unescaping, I guess this isn't great? https://github.com/sinatra/sinatra/blob/5640495babcb4cfd69ba650b293660b7446402da/sinatra-contrib/lib/sinatra/cookies.rb#L321
I'm going with the more conservative approach to start with (https://github.com/sinatra/sinatra/pull/2035/commits/9e07d4f2bc324bdf3912bbef41b9039970f30b5a)
I hope to get to it
Test passed when the build was re-run. I will allow JRuby to fail for now, leaving this open as a reminder.
jruby-head (`jruby 9.4.9.0-SNAPSHOT (3.1.4) 2024-11-04 746b84aa02 OpenJDK 64-Bit Server VM 11.0.25+9 on 11.0.25+9 +jit [x86_64-linux]`) failed at https://github.com/sinatra/sinatra/actions/runs/11726432582/job/32665062599#step:5:28 but the jruby build had no problems ``` 1) Error: IntegrationTest#test_with_puma_sets_the_app_file_0: Net::HTTPBadResponse:...