denisenkom

Results 51 comments of denisenkom

This looks like some kind of debugging improvement which probably should not change public interface. Maybe you should use logging to achieve the same goal?

Once this change introduced it becomes something that cannot be changed in non backward-compatible way. Also there is a good chance that users would like to distinguish other kinds of...

Can you add tests for this new feature. Also how do you make sure it is backward compatible?

Can you provide a reproducible example?

Why do you think this is the right way of adding new type support?

You need to add a roundtrip test with the actual SQL server. One test should set a value in the SQL and read it uniqueidentifier. Another test should verify sending...

I don't like exposing so much of internal structures as an interface. That would make it much harder to change internals without introducing a breaking change in the interface. Is...

You should add tests with unicode characters, to demonstrate that this works. I also don't think what you are doing would actually work, you would need to convert to some...