go-mssqldb icon indicating copy to clipboard operation
go-mssqldb copied to clipboard

return error of type 'mssql.Error' directly, because the Number in 'm…

Open sdghchj opened this issue 4 years ago • 2 comments

…ssql.Error' is useful for logic behavior.

fix the issue: #577

sdghchj avatar May 07 '20 09:05 sdghchj

Codecov Report

Merging #578 into master will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   68.72%   68.72%           
=======================================
  Files          23       23           
  Lines        5190     5190           
=======================================
  Hits         3567     3567           
  Misses       1410     1410           
  Partials      213      213           
Impacted Files Coverage Δ
tds.go 61.03% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06a60b6...efff2aa. Read the comment docs.

codecov[bot] avatar May 07 '20 09:05 codecov[bot]

Can you add tests for this new feature. Also how do you make sure it is backward compatible?

denisenkom avatar Nov 03 '20 23:11 denisenkom