go-mssqldb icon indicating copy to clipboard operation
go-mssqldb copied to clipboard

Refactor out all mssql defined data types into a mssqltypes subpackage

Open yukiwongky opened this issue 4 years ago • 4 comments

Part of issue #357

yukiwongky avatar Sep 13 '19 00:09 yukiwongky

Codecov Report

Merging #518 into master will decrease coverage by 0.17%. The diff coverage is 26.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   68.67%   68.49%   -0.18%     
==========================================
  Files          22       20       -2     
  Lines        5056     4984      -72     
==========================================
- Hits         3472     3414      -58     
+ Misses       1379     1367      -12     
+ Partials      205      203       -2
Impacted Files Coverage Δ
mssql.go 81.59% <0%> (ø) :arrow_up:
mssql_go19.go 95.65% <100%> (ø) :arrow_up:
buf.go 100% <100%> (ø) :arrow_up:
types.go 77.29% <16.66%> (ø) :arrow_up:
bulkcopy.go 57.74% <44.44%> (ø) :arrow_up:
token.go 55.91% <7.54%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19fca52...1844e83. Read the comment docs.

codecov[bot] avatar Sep 13 '19 00:09 codecov[bot]

Codecov Report

Merging #518 into master will decrease coverage by 0.13%. The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   68.86%   68.72%   -0.14%     
==========================================
  Files          22       20       -2     
  Lines        5058     5004      -54     
==========================================
- Hits         3483     3439      -44     
+ Misses       1369     1361       -8     
+ Partials      206      204       -2
Impacted Files Coverage Δ
error.go 75% <ø> (ø) :arrow_up:
mssql_go19.go 95.65% <100%> (ø) :arrow_up:
types.go 77.29% <100%> (ø) :arrow_up:
bulkcopy.go 57.74% <44.44%> (ø) :arrow_up:
mssql_go19pre.go

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfbb681...c0df4eb. Read the comment docs.

codecov[bot] avatar Sep 13 '19 00:09 codecov[bot]

I've pulled Error out from this PR. @denisenkom can you check?

yukiwongky avatar Oct 07 '19 23:10 yukiwongky

This needs to be rebased

denisenkom avatar Nov 04 '20 00:11 denisenkom