go-mssqldb icon indicating copy to clipboard operation
go-mssqldb copied to clipboard

Add Nullable version of uniqueidentifier

Open jeebiq opened this issue 3 years ago • 3 comments

jeebiq avatar Sep 29 '20 12:09 jeebiq

Why do you think this is the right way of adding new type support?

denisenkom avatar Nov 03 '20 22:11 denisenkom

I didn't see anything in the readme about how you wished to have anything new added, so I added as new/dedicated files to keep it as simple as possible for me without touching the existing code.

jeebiq avatar Nov 04 '20 07:11 jeebiq

You need to add a roundtrip test with the actual SQL server. One test should set a value in the SQL and read it uniqueidentifier. Another test should verify sending uniqueidentifier value into SQL server and then read it back and compare with original. Each test should test actual value and NULL.

denisenkom avatar Nov 05 '20 00:11 denisenkom