Roman Shtylman

Results 329 comments of Roman Shtylman

@tonynajjar If you have the ability to incorporate this change into your workspace you can give this a try as a fix for https://github.com/ros2/rosbag2/issues/1597

> That is why the solution with creating a temporary empty file with the same name as the original currently recording file but with the `.active` extention instead of renaming...

> Also, need to consider if we want to add the same `.active` suffix when we are openning storage with `append` mode. Not sure what would be an implication from...

A few thoughts after a quick review: 1. I don't like the undocumented and un-commented `MCAP_STATIC_DEFINE` 2. This seems like an issue created by `mcap_builder` and not specific to the...

@wrightsg ping on updating the readme and then we can merge

Closing due to inactivity. If this is still relevant even after https://github.com/foxglove/mcap/pull/1431 as mentioned above please let us know.

Is it actually true that the value could be _any_ though? Seems like the change to have the specific type it could be is a better direction than going back...

I'm a bit _meh_ on the CLI tool working directly on remote files but I see we already have GCS support. Is there anything else you need in this PR...

Is this PR ready for review? It is still marked as draft. If you have lost interest can we close it?

I'm gonna close this since there's been no response to my last inquiry for some time. If you decide to re-visit we can consider it again.