Dimitris Efstathiou

Results 26 comments of Dimitris Efstathiou

Hi @nibou230! Regarding the API, all the data that you are after seem to be contained into the Review process, so it could make sense to start with working on...

> Hi @defstat, thank you for the help. > > I'll look at the Jats controller and make another one specific for the reviews. > > I understand the point...

@nibou230 hi! Regarding your question on the `reviewerId` and whether [this](https://github.com/pkp/pkp-lib/pull/9526/files#diff-d2395d3a8bc46421de23d6b0d02d0f2af245303a22b2a3a481b9501b68803e19R100) is the way to go, or whether you need to add the `reviewerId` as an input parameter to the...

> Hi everyone, I'm mostly done with the development. You can see a preview of the review history here. > > @jardakotesovec The URL used to download the file isn't...

I would suggest, before a more specific review, to add the application specific (OJS) changes to OMP at least, and add PRs for both OMP and OPS for the tests...

> I am not sure what happened here now. I was pushing the new changes to the pr and when I came here I can see that the pr is...

@Vitaliy-1 this is a [PR](https://github.com/pkp/pkp-lib/pull/9675) that removes `StageAssignmentDAO` and `StageAssignment` from the codebase in favor of a new `StageAssignment` Eloquent Model. If you have some time, could you review it,...

@Vitaliy-1 thanks for the code review. I have resolved most of the comments and added 1-2 new comments for clarification. Because there are one-or-two review changes that may affect the...

@asmecher @Vitaliy-1 I have changed the repository functions to the plural form. I have rebased and pushed, the tests seem to be passing. Before merging them, I would like for...

> Shouldn't Laravel convert the camel case into snake case automatically? I thought it should but it seems that in the case of the `->update` function it keeps using the...