Dimitris Efstathiou

Results 26 comments of Dimitris Efstathiou

@Vitaliy-1 If you are referring to Accessors and Mutators I am already using them, but it seems that in the case of `->update` the code does not go through that...

@Vitaliy-1 thanks. I changed the code to update the `$stageAssignments` one by one using your proposal. I updated the PRs and the tests seem to be passing.

@Vitaliy-1 @asmecher everything merged on `pkp-lib`, `ojs`, `omp`, `ops`. Leaving it open for plugins

@asmecher I have not yet gone through all plugins for making the necessary changes regarding this.

@jardakotesovec thanks for the tips. I added some proposed PRs in the issue's starting comment. I removed vue3-highlightjs and from highlight.js I used only XML language. They are ready for...

> @defstat Nice to see the size reduction. I made some suggestions, let me know what you think. Thanks @jardakotesovec. Please find new PRs at the initial comment of the...

> @defstat That looks great. One thing that I am wondering about is - are we going to use that functionality in omp or ops? > > If not maybe...

No OMP and OPS is not using it right now. I will try the approach you are proposing. Do you have a preference in which folder inside the `src/components` to...

ok @jardakotesovec! I added the possibility of selecting from a set of languages and pushed the code. We can either 1. leave those, 2. add only XML or 3. add...

@jardakotesovec thanks. I think I concluded the review changes required and added the appropriate files for the StoryBook. Pushed everything for your approval.