ojs
ojs copied to clipboard
pkp
pkp/pkp-lib#7165 Issue datePublished can be set when adding an issue
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Antti-Jussi Nygård seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@NateWr for some reason I remembered that this got merged already a while ago. The tests went through back in December and all the changes should be there. I rebased and started the tests again.
I am not sure what happened here now. I was pushing the new changes to the pr and when I came here I can see that the pr is closed? @asmecher if I accidentally merged something (can not see in the commit history in OJS that I have) then please reverse that. In the meantime can someone else reopen this pr because I can't?
Have not seen anything before with pr's
I am not sure what happened here now. I was pushing the new changes to the pr and when I came here I can see that the pr is closed? @asmecher if I accidentally merged something (can not see in the commit history in OJS that I have) then please reverse that. In the meantime can someone else reopen this pr because I can't?
Have not seen anything before with pr's
I think that If you add some changes to this PR it will enable the "Reopen and comment" for you.
I show a notification that "ajnyga added 0 commits", and if you see there are no commits in that PR
ah ok I see, I had upgraded to PHP 8.3 and it seems that PHP-CS-Fixer does not work with that version and that leads to empty commits, just did not read what the console was telling me :D
PHP needs to be a minimum version of PHP 7.4.0 and maximum version of PHP 8.2.*.
Current PHP version: 8.3.4.
To ignore this requirement please set `PHP_CS_FIXER_IGNORE_ENV`.
If you use PHP version higher than supported, you may experience code modified in a wrong way.
Please report such cases at https://github.com/PHP-CS-Fixer/PHP-CS-Fixer .
husky - pre-commit hook exited with code 1 (error)
Some of the tests are failing, but it seems that in a point where my additions should not have an effect?