Dean Karn

icon indicating an email [email protected]

icon company @HubSpot icon location /dev/tty0 icon location I love to code, design and mentor with the mantra "simple is beautiful"

Results 186 comments of Dean Karn

Add support for skip_unless tag in validator

Thanks for the PR @JahanviAggarwal , sorry it took me this long to get to it. Would you be able to resolve the conflicts and I can get it merged.

Add cron validation

looks like I already merged a CRON validation in this PR https://github.com/go-playground/validator/pull/1045

add reflect struct field on validate error

@ivybridge-3c33 I like the idea of grabbing struct field, I wonder if it might be confusing though for when the validation is not a struct field. I wonder if there...

feat(BREAKING): Change CIDRIPv4 validation

Hey @martinlehoux sorry for letting this one slip through the cracks. yes I will try to merge tomorrow.

Panic Bad field type *int64, when using required_if and omitempty at the same time

Sorry for the delay in responding, stealing some time before the kids are up to comment. I don't believe there is an issue here and that the validations defined is...

Go Producer Much slower than Python Producer

I'm also seeing this with a very low flow producer, maybe 1rps(a test application not in production yet why so low). I have `queue.buffering.max.ms` set to `5ms` and `required acks`...

Order is not working w.r.t the required_with and len tag

Yes that’s the way I expected those tags to work also, but they aren’t documented that way. gonna have to double check if it ever behaved that way before. Will...

MongoDB validator improved

I'm not sure it would be best to have one validation do two different things, otherwise you wouldn't be able to differentiate for error messages and alike what exactly failed.

add domain validation(simple domain names)

@aryehlev I'm hesitant to merge this only because full domain validation is much more complicated than this and don't want to give users a false sense of security. if a...

update crypto and sys to 202208 versions

This looks like dependency has been upgraded since PR was made, TY. Closing.